Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up ClimaEarth environment #1070

Merged
merged 4 commits into from
Nov 13, 2024
Merged

clean up ClimaEarth environment #1070

merged 4 commits into from
Nov 13, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Nov 7, 2024

Purpose

This PR does a few cleanup tasks in the experiments/ClimaEarth/ directory:

  • Update the ClimaEarth README
  • Delete the viz_explorer.jl, which was previously used to create animations of simulation fields, but is not currently being used.
  • Move functions in the io_helpers.jl file to the Utilities module and delete this file. This should not change any behavior.
  • Move checkpoint_sims function to the Checkpointer module and delete the user_logging.jl file. This should not change any behavior.

closes #1067

To-do

  • verify only change in behavior/outputs is animation removal

Content

  • move exp/ClimaEarth/AMIP_log.md into exp/ClimaEarth/README.md and delete AMIP_log
    • also add more details for slabplanet
  • viz_explorer.jl
    • delete (unused; link in NEWS.md in case we want to add back later)
  • io_helpers.jl
    • move to src/ (general helpers)
  • user_logging.jl
    • delete show method (unused)
    • checkpoint_sims --> move to Checkpointer module

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/climaearth branch 4 times, most recently from bbc6411 to b64f3c2 Compare November 8, 2024 00:32
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to change a few things in the checkpoint PR

Delete the viz_explorer.jl, which was previously used to create animations
of simulation fields, but is not currently being used.
Move functions in the io_helpers.jl file to the Utilities module
and delete this file. This should not change any behavior.
Move checkpoint_sims function to the Checkpointer module and delete
the user_logging.jl file. This should not change any behavior.
@juliasloan25 juliasloan25 merged commit 4f12863 into main Nov 13, 2024
9 checks passed
@juliasloan25 juliasloan25 deleted the js/climaearth branch November 13, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove easily-removable files in experiments/ClimaEarth/
2 participants