Switch to PartitionedFluxes #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/tubu
branch
4 times, most recently
from
61c4a4a to
cca017f
Compare
`CombinedStateFluxes`, while simple, is not super physically less sound (combining states of different component models into a single average state is necessarily the best idea). In addition to this, `CombinedStateFluxes` relies on the infrastructure in ClimaAtmos to compute turbulent fluxes, which is highly complex and difficult to understand. This commit fixes `PartionedStateFluxes` and switches all the jobs to use this system. `PartionedStateFluxes` was broken for certain jobs because it was not setting certain values, such as ustar, which are needed (e.g., in EDMF). In this commit, we also change how surface temperature is propagated to atmos. Here, we take directly the area-weighted value computed from the surface models and directly set it in atmos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CombinedStateFluxes, while simple, is not super physically less sound (combining states of different component models into a single average state is necessarily the best idea). In addition to this,CombinedStateFluxesrelies on the infrastructure in ClimaAtmos to compute turbulent fluxes, which is highly complex and difficult to understand.This commit fixes
PartionedStateFluxesand switches all the jobs to use this system.PartionedStateFluxeswas broken for certain jobs because it was not setting certain values, such as ustar, which are needed (e.g., in EDMF).In this commit, we also change how surface temperature is propagated to atmos. Here, we take directly the area-weighted value computed from the surface models and directly set it in atmos.