Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ClimaLandSimulation struct #1199

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Feb 19, 2025

Purpose

closes #1182

Adds a struct ClimaLandSimulation for the full, integrated land model. This PR also extends the necessary Interfacer functions for a simulation type (get_field, update_field!, step!, etc).

This PR requires CliMA/ClimaLand.jl#1035 from ClimaLand, so it uses that branch in the experiments/ClimaEarth/ environment. That PR will need to be merged and a release of ClimaLand made before we can merge this PR.

To Do

  • add get_field functions
  • extend new get_field functions for other surface models
    • emissivity -> return 1
    • displacement height -> return 0
  • add update_field! functions
  • update Interfacer docs
    • Q: do we want to require these fields to be extended for all surface model simulations? Or just add fallbacks that do nothing?
  • add method for add_coupler_fields!, following add coupler fields based on simulation types #1207
  • add test for constructor

Current status 2/27

Constructor fails in update_aux! because snow tries to access p.drivers.thermal_state.

@juliasloan25 juliasloan25 force-pushed the tr/add-ClimaLandModel-struct branch 2 times, most recently from 4aed9d1 to 9caed36 Compare February 24, 2025 22:15
@juliasloan25 juliasloan25 changed the title Tr/add clima land model struct add ClimaLandSimulation struct Feb 26, 2025
@juliasloan25 juliasloan25 force-pushed the tr/add-ClimaLandModel-struct branch 3 times, most recently from 9c5fcd4 to 808d188 Compare February 27, 2025 18:04
@juliasloan25 juliasloan25 force-pushed the tr/add-ClimaLandModel-struct branch from 808d188 to 818bf24 Compare February 28, 2025 01:05
@juliasloan25 juliasloan25 force-pushed the tr/add-ClimaLandModel-struct branch from 818bf24 to 54c3699 Compare February 28, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ClimaLandModel struct and interfacing functions
2 participants