add GPU slabplanet file read albedo runs #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
changed the title
juliasloan25
changed the title
juliasloan25
force-pushed
the
js/slabplanet-albedo-static
branch
2 times, most recently
from
a65f651 to
d77c21a
Compare
juliasloan25
force-pushed
the
js/slabplanet-albedo-static
branch
3 times, most recently
from
3d631af to
8756b78
Compare
juliasloan25
force-pushed
the
js/slabplanet-albedo-static
branch
from
8756b78 to
079f558
Compare
LenkaNovak
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
LGTM, Julia. I hadn't appreciated just how much the GPU runs depart from the CPU ones. This is beyond the floating point errors / small mismatches in energy checks. Let's try to target #607 next.
| @@ -349,7 +349,23 @@ steps: | |||
| - label: "GPU Slabplanet: albedo from function" | |||
| key: "gpu_slabplanet_albedo_function" | |||
| command: "julia --color=yes --project=experiments/AMIP/ experiments/AMIP/coupler_driver.jl --config_file $CONFIG_PATH/gpu_slabplanet_albedo_function.yml" | |||
| artifact_paths: "experiments/AMIP/output/gpu/slabplanet/gpu_slabplanet_albedo_function_artifacts/*" | |||
| artifact_paths: "experiments/AMIP/output/slabplanet/gpu_slabplanet_albedo_function_artifacts/*" | |||
There was a problem hiding this comment.
Hmm, looking at the conservation plots, there is definitely something wrong with energy for the GPU runs. I would expect these to be that different. E.g. for function CPU v GPU:
It would be good for us to try to debug this as the next step.
juliasloan25
force-pushed
the
js/slabplanet-albedo-static
branch
from
079f558 to
3beeccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add GPU slabplanet runs reading albedo from a static input file and from a temporally-varying input file.
closes #590
part of #390
note: this PR changes GPU runs to soft fail conservation checks. I've opened an issue here so we remember to revisit this: #607
note also: we can't currently show animations for these runs because they aren't GPU-compatible, but we have an issue for this too #613
Current status
To do