Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for AMIP #591

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Fixes for AMIP #591

merged 1 commit into from
Feb 3, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Feb 2, 2024 •
edited
Loading

closes #568

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak mentioned this pull request Feb 2, 2024
Closed
1 task
@LenkaNovak LenkaNovak force-pushed the ln/fixes-for-longruns2 branch 3 times, most recently from 7f2ff40 to d2d838d Compare February 2, 2024 15:26
@LenkaNovak LenkaNovak marked this pull request as ready for review February 2, 2024 15:53
juliasloan25
juliasloan25 reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments

test/component_model_tests/climaatmos_standalone/atmos_driver.jl Show resolved Hide resolved
src/ConservationChecker.jl Show resolved Hide resolved
experiments/AMIP/components/land/bucket_utils.jl Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_init.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
experiments/AMIP/Manifest.toml Outdated Show resolved Hide resolved
config/longrun_configs/amip_target.yml Show resolved Hide resolved
szy21
szy21 reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on the config file.

config/longrun_configs/amip_target.yml Show resolved Hide resolved
config/longrun_configs/amip_target_topo.yml Outdated Show resolved Hide resolved
config/longrun_configs/amip_target_topo.yml Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/fixes-for-longruns2 branch from ca5b8e0 to d9b8678 Compare February 2, 2024 22:27
@LenkaNovak
cp from ln/fixes-for-longruns + rebase
5ae8d08 
revert to min changes

pkg project

clean

pip fix

ρ_ice

conserving. add info for cc

conserving. add info for cc

add asserts

clean up cons checks

add softfails

add longrun softfails, amip netcdf_int

clean

rev2, firerson, using ref, only amip in bk

all longruns

add back topo ref state

add back topo ref state

vert_diff: "true", use_reference_state: false

re pip
@LenkaNovak LenkaNovak force-pushed the ln/fixes-for-longruns2 branch from dd8fda6 to 5ae8d08 Compare February 3, 2024 18:02
@LenkaNovak LenkaNovak merged commit 914f83d into main Feb 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 left review comments

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small fixes for conservation
3 participants
@LenkaNovak @szy21 @juliasloan25