Add infrastructure to compute errors against observations #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
changed the title
Sbozzolo
force-pushed
the
gb/leaderboard
branch
from
d830d52 to
1cdb4ae
Compare
|
|
szy21
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Thanks Gabriele! Here are a few minor comments. I need to spend more time understanding how sampling over time works, but other than that it looks good. Also If I understand correctly it is now plotting the rmse map, not the bias map you showed in the comment?
| A struct to describe some observation data that we want to compare against. | ||
|
|
||
| """ | ||
| struct ObsDataSource |
There was a problem hiding this comment.
Just note that we will compare with data that has a z dimension as well, but we can add that when we are actually doing it.
| A struct to describe some simulation data. | ||
|
|
||
| """ | ||
| struct SimDataSource |
There was a problem hiding this comment.
Same here, we will need the height information in the future.
Sbozzolo
force-pushed
the
gb/leaderboard
branch
3 times, most recently
from
ca0935c to
39a6a6c
Compare
Sbozzolo
force-pushed
the
gb/leaderboard
branch
8 times, most recently
from
1e536e8 to
ae00d5b
Compare
Sbozzolo
force-pushed
the
gb/leaderboard
branch
3 times, most recently
from
6d24cde to
9c832eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new module,
Leaderboard, currently living in the AMIP experiment.LeaderboardusesNCDatasetsandClimaAnalysisto compute error maps between observations and simulations.Leaderboarddefines two new structsObsDataSourceandSimDataSource.ObsDataSourcedescribes some observational data (contained a NetCDF file) by specifying the name of the variable and other attributes.SimDataSourcedoes the same for simulated (atmos) data.The
rmseerror takes these two data structures and a target date, resamples the observational data to the simulated output grid (with a 0th order interpolation scheme, ie nearest neighbors). Then, it computesThis variable is neatly packaged in a
ClimaAnalysis.OutputVarso that it can be directly plotted.Leaderboardalso provides an numerical integration routine on the sphere. Withintegrate_on_spherethe RMSE can be integrated over the sphere to condense it to a single number (a 1/4pi might be needed to normalize the integration volume). These values are saved in the attributes of theOutputVarproduced bybias.Closes #407