rm bycolumn #805
Merged
rm bycolumn #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/bycolumn
branch
2 times, most recently
from
25d12a9 to
6f571c3
Compare
juliasloan25
force-pushed
the
js/bycolumn
branch
6 times, most recently
from
d0d677e to
3730789
Compare
juliasloan25
commented
Jun 25, 2024
juliasloan25
force-pushed
the
js/bycolumn
branch
2 times, most recently
from
caf579d to
19a90c5
Compare
juliasloan25
force-pushed
the
js/bycolumn
branch
from
0115bb7 to
653609c
Compare
Sbozzolo
approved these changes
Jun 25, 2024
| end | ||
| function surface_inputs(::MoninObukhovScheme, input_args::NamedTuple) | ||
| (; thermo_state_sfc, thermo_state_int, uₕ_int, z_int, z_sfc, scheme_properties) = input_args | ||
| (; thermo_state_sfc, thermo_state_int, uₕ_int, z_int, z_sfc, scheme_properties, boundary_space) = input_args |
There was a problem hiding this comment.
Can we instead grab boundary_space from axes(z_sfc)? Or will that not work?
There was a problem hiding this comment.
axes(z_sfc) is different from boundary_space so I don't think that's what we want. I tried getting it from axes(beta), but beta is sometimes a scalar so that didn't work either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #736
Results
Content:
bycolumnremoved fromexperiments/ClimaEarth/components/atmosphere/climaatmos_extra_diags.jlsrc/FluxCalculator.jl.update_turbulent_fluxes(used for partitioned turbulent fluxes)get_field,update_field!methods for component modelsexperiments/ClimaEarth/components/ocean/eisenman_seaice.jlsolve_eisenman_model