Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add downward sw fluxes to leaderboard #927

Merged
merged 2 commits into from
Aug 15, 2024
Merged

add downward sw fluxes to leaderboard #927

merged 2 commits into from
Aug 15, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Aug 15, 2024

Purpose

Also adds option to shift ObsDataSources to end of month. This helps with comparing with our model because observations are typically defined on the 15th, but our model is defined at the end of the month. Since we always find the closest data available, this can lead to comparisons across months.

To-do

Content


  • I have read and checked the items on the review checklist.

@Sbozzolo Sbozzolo self-requested a review August 15, 2024 00:28
@szy21
Copy link
Member Author

szy21 commented Aug 15, 2024

It's slightly better.
without the shift:
Screenshot 2024-08-14 at 5 38 40 PM
with the shift:
Screenshot 2024-08-14 at 5 39 06 PM

@szy21 szy21 enabled auto-merge August 15, 2024 00:55
@Sbozzolo
Copy link
Member

I added experimental support for actual monthly averages here:
CliMA/ClimaDiagnostics.jl#67
CliMA/ClimaAtmos.jl#3235

@Sbozzolo
Copy link
Member

Buildkite might be failing for some ClimaLand file issues. We fixed them and i just released ClimaLand 0.14.2, you should try updating it.

@szy21 szy21 disabled auto-merge August 15, 2024 04:42
@szy21
Copy link
Member Author

szy21 commented Aug 15, 2024

Great, thank you!

szy21 and others added 2 commits August 15, 2024 13:48
This helps with comparing with our model because observations are
typically defined on the 15th, but our model is defined at the end of
the month. Since we always find the closest data available, this can
lead to comparisons across months.
@Sbozzolo Sbozzolo merged commit f3c6840 into main Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants