run with more diagnostics #1024
Open
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
force-pushed
the
kd/long_run_more_diagnostics
branch
2 times, most recently
from
1625895 to
95b62ed
Compare
kmdeck
commented
Feb 13, 2025
| @@ -329,20 +329,23 @@ function default_diagnostics( | |||
| "gpp", | |||
| "ct", | |||
| "lai", | |||
| "sco2", | |||
There was a problem hiding this comment.
this is mostly NaN right now anyways... we can add it back later when we have time to debug it
juliasloan25
approved these changes
Feb 13, 2025
| land_model::Union{SoilCanopyModel{FT}, LandModel{FT}}, | ||
| ) where {FT} | ||
| if isnothing(out) | ||
| return p.canopy.energy.turbulent_fluxes.transpiration .* 1000 |
There was a problem hiding this comment.
could you add a comment explaining why .* 1000?
| @@ -492,7 +492,7 @@ for (group_id, group) in | |||
| CairoMakie.save(joinpath(root_path, "$(group_name).png"), fig) | |||
| end | |||
|
|
|||
| short_names = ["gpp", "swc", "et", "ct", "swe", "si"] | |||
| short_names = ["gpp", "swc", "et", "ct", "swe", "si", "trans", "msf"] | |||
There was a problem hiding this comment.
we could also add these to short_names_bio/short_names_other above too if we want the heatmaps to be in the bio/other png outputs
There was a problem hiding this comment.
right now i never look at those plots...but all of these are plotted in "figures.pdf"
kmdeck
force-pushed
the
kd/long_run_more_diagnostics
branch
from
6817731 to
0642adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Content