Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small parameterization changes + fluxnet site parameters #993

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jan 27, 2025

Purpose

Improve certain parameterizations and parameter values

To-do

A future branch will contain the scripts for fluxnet paper plots - these are tailored to certain sites based on what data is available. Our current run_fluxnet is more general. We can decide to merge them or not

Content


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck requested a review from AlexisRenchon January 28, 2025 19:13
@kmdeck
Copy link
Member Author

kmdeck commented Jan 28, 2025

vaira_soil
vaira_monthly

@kmdeck kmdeck force-pushed the kd/paper_fluxnet_plots branch from 7a7d358 to d6a4db7 Compare January 30, 2025 18:24
@kmdeck kmdeck marked this pull request as ready for review January 30, 2025 21:49
@kmdeck kmdeck force-pushed the kd/paper_fluxnet_plots branch from 75bd63a to dd5ff5a Compare January 30, 2025 23:48
Copy link
Member

@AlexisRenchon AlexisRenchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me!

@AlexisRenchon
Copy link
Member

I approved you PR but if you want we can add months name, like this

            ax = Axis(
                fig_seasonal_cycle[1, 1],
                xlabel = "Month of the year",
                ylabel = "$short_name [$(ClimaAnalysis.units(var))]",
                xticks = (
                    1:1:12,
                    [
                        "Jan",
                        "Feb",
                        "Mar",
                        "Apr",
                        "May",
                        "Jun",
                        "Jul",
                        "Aug",
                        "Sep",
                        "Oct",
                        "Nov",
                        "Dev",
                    ],
                ),
            )

(or similar)

you can also do CairoMakie.xlims!(ax, 1, 12) if you don't want blank space left and right (but that is a bit personal preference)

for the first figure (volumetric water and temperature), you masked the x-axis tick label for the top 2 subplots, but not the 3rd
could be "day of the year" instead of "days"
alternatively, you could use xticks as above to put months name at 1:30:365, and call it month of the year (you can change ticks to actual month length instead of steps 30)

@kmdeck kmdeck force-pushed the kd/paper_fluxnet_plots branch from 94c7bf5 to 4e1d35a Compare January 31, 2025 17:44
@kmdeck kmdeck enabled auto-merge (squash) January 31, 2025 17:50
@kmdeck kmdeck merged commit 27accf4 into main Jan 31, 2025
16 checks passed
@kmdeck kmdeck deleted the kd/paper_fluxnet_plots branch January 31, 2025 19:06
@kmdeck kmdeck mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants