Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher resolution output #998

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Higher resolution output #998

merged 1 commit into from
Jan 31, 2025

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Jan 30, 2025

Purpose

We currently store 180x90 points in lat/lon, but this causes poor quality figures along coastlines in particular, and doesnt make use of the higher resolution of our simulation (~0.2 degrees). This increases the resolution of the stored output. For monthly output the extra size is OK.

To-do

Content

We have ~101x101x4x4 points in our simulation. The output now has 570x285 points. This is a ratio of ~1 output point to simulation point


  • I have read and checked the items on the review checklist.

@kmdeck kmdeck marked this pull request as ready for review January 30, 2025 23:59
@kmdeck kmdeck requested a review from juliasloan25 January 30, 2025 23:59
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only suggestion would be to add the in-line comments explaining why we use these numbers

@kmdeck kmdeck force-pushed the kd/improve_global_plots branch from 24736c8 to 54866e7 Compare January 31, 2025 01:50
@kmdeck
Copy link
Member Author

kmdeck commented Jan 31, 2025

Looks good, my only suggestion would be to add the in-line comments explaining why we use these numbers

thanks for the quick review! I added comments in

@kmdeck kmdeck enabled auto-merge (squash) January 31, 2025 01:51
@kmdeck kmdeck merged commit faee373 into main Jan 31, 2025
15 of 16 checks passed
@kmdeck kmdeck deleted the kd/improve_global_plots branch January 31, 2025 03:00
@kmdeck kmdeck restored the kd/improve_global_plots branch February 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants