Fix type instability #157
Open
Fix type instability #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
reviewed
Feb 24, 2025
| dimensions_FT = map(dimensions, regridder.dim_increasing) do dim, increasing | ||
| !increasing ? reverse(FT.(dim)) : FT.(dim) | ||
| end | ||
| dimensions_FT = ntuple( |
There was a problem hiding this comment.
Can you also add a check to check that the number of dimensions match between the given data and the space?
ext/InterpolationsRegridderExt.jl
Outdated
| """Tuple of integers indicating which dimensions to reverse in data""" | ||
| decreasing_indices::DI | ||
|
|
||
| "Number of dimensions" |
There was a problem hiding this comment.
What is this the number of dimensions for?
There was a problem hiding this comment.
It is the number of dimensions of the space.
There was a problem hiding this comment.
Which space? The target space? And is it number of physical dimensions? Can we update the doc string to make this more clear?
ph-kev
force-pushed
the
kp/allocs
branch
2 times, most recently
from
2251e7d to
bc7390b
Compare
This commit fixes the type instabilities in Regridders.regrid and DataHandling.regridded_snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the type instability of
DataHandling.regridded_snapshotandRegridders.regrid.