Fix Biharmonic Viscosity on Cubed-Sphere Grid #3850
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Oct 18, 2024
Comment on lines
+81
to
+82
| @inline Δy_∇²u(i, j, k, grid, closure, u, v) = Δy_qᶠᶜᶜ(i, j, k, grid, biharmonic_mask_x, ∇²hᶠᶜᶜ, u) | ||
| @inline Δx_∇²v(i, j, k, grid, closure, u, v) = Δx_qᶜᶠᶜ(i, j, k, grid, biharmonic_mask_y, ∇²hᶜᶠᶜ, v) |
There was a problem hiding this comment.
Are ∇²v and ∇²u still appropriate names for these operators? It's a bit confusing.
glwagner
reviewed
Oct 19, 2024
src/TurbulenceClosures/turbulence_closure_implementations/scalar_biharmonic_diffusivity.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Gregory L. Wagner <[email protected]>
navidcy
added
numerics 🧮
siddharthabishnu
added a commit
that referenced
this pull request
Oct 21, 2024
glwagner
reviewed
Oct 22, 2024
src/TurbulenceClosures/abstract_scalar_biharmonic_diffusivity_closure.jl
Outdated
Show resolved
Hide resolved
src/TurbulenceClosures/turbulence_closure_implementations/scalar_biharmonic_diffusivity.jl
Outdated
Show resolved
Hide resolved
src/TurbulenceClosures/turbulence_closure_implementations/scalar_biharmonic_diffusivity.jl
Outdated
Show resolved
Hide resolved
…ar_biharmonic_diffusivity.jl Co-authored-by: Simone Silvestri <[email protected]>
…ar_biharmonic_diffusivity.jl Co-authored-by: Simone Silvestri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3849.