Merge pull request #425 from zdyj3170101136/fix/col_low_cardinity

perf(col_low_cardinality): use small value.
ClickHouse · Oct 17, 2024 · 73fa62f · 73fa62f
2 parents ea7df0e + 618b1c1
commit 73fa62f
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/proto/col_low_cardinality.go b/proto/col_low_cardinality.go
@@ -321,17 +321,6 @@ func (c ColLowCardinality[T]) Rows() int {
 
 // Prepare column for ingestion.
 func (c *ColLowCardinality[T]) Prepare() error {
-	// Select minimum possible size for key.
-	if n := len(c.Values); n < math.MaxUint8 {
-		c.key = KeyUInt8
-	} else if n < math.MaxUint16 {
-		c.key = KeyUInt16
-	} else if uint32(n) < math.MaxUint32 {
-		c.key = KeyUInt32
-	} else {
-		c.key = KeyUInt64
-	}
-
 	// Allocate keys slice.
 	c.keys = append(c.keys[:0], make([]int, len(c.Values))...)
 	if c.kv == nil {
@@ -352,6 +341,17 @@ func (c *ColLowCardinality[T]) Prepare() error {
 		c.keys[i] = idx
 	}
 
+	// Select minimum possible size for key.
+	if n := last; n < math.MaxUint8 {
+		c.key = KeyUInt8
+	} else if n < math.MaxUint16 {
+		c.key = KeyUInt16
+	} else if uint32(n) < math.MaxUint32 {
+		c.key = KeyUInt32
+	} else {
+		c.key = KeyUInt64
+	}
+
 	// Fill key column with key indexes.
 	switch c.key {
 	case KeyUInt8: