implement Exception.Unwrap method #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
husio
force-pushed
the
exception_unwrap
branch
from
45cb154 to
201ad9b
Compare
serprex
approved these changes
Oct 13, 2024
serprex
force-pushed
the
exception_unwrap
branch
2 times, most recently
from
cbb717d to
57d2bd4
Compare
In order to make exceptions testable with errors.Is, they must implement
the `Unwrap` method to allow access to the underlying error code(s).
This change is addressing the problem of the below code not working as
expected, when testing returned by `Do` method error:
c, _ := ch.Dial(ctx, ch.Options{...})
switch err := c.Do(ctx, ch.Query{...}); {
case err == nil:
// ...
case errors.Is(err, proto.ErrTableIsReadOnly), errors.Is(err, proto.ErrReadonly):
// ... <- Never executed, because exception unwraping is not implemented.
default:
// ...
}
Because `Exception` instances are created dynamically, unwrapping can
ignore nested exception instances and collect only underlying error codes.
serprex
force-pushed
the
exception_unwrap
branch
from
57d2bd4 to
133e888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make exceptions testable with errors.Is, they must implement the
Unwrapmethod to allow access to the underlying error code(s).This change is addressing the problem of the below code not working as expected, when testing returned by
Domethod error:Because
Exceptioninstances are created dynamically, unwrapping can ignore nested exception instances and collect only the underlying error codes.