Fix client default read timeout setting #415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I removed setting zero timeout in case of passed negative value.
The problem occurs when we call
client.Dial
:ReadTimeout
value isNoTimeout
, we set it to zero.client.Connect
method, we callopt.setDefault
as well here, but by this momentreadTimeout
had been already set to default value zero, and here it would be interpreted as time duration zero value and be set toDefaultReadTimeout
.To prevent this error it is sufficient just to remove setting
ReadTimeout
to zero and leave it with negative value, because here is the only place it is used and current check is enough.