Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: infer Decimal #434

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: infer Decimal #434

merged 1 commit into from
Oct 15, 2024

Conversation

serprex
Copy link
Member

@serprex serprex commented Oct 13, 2024 •
edited
Loading

relevant docs

Infer Decimal(P, S) to its subtype. Ignore scale

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@serprex serprex requested review from genzgd and ernado October 13, 2024 06:27
@serprex serprex mentioned this pull request Oct 13, 2024
Draft
@ernado
Copy link
Collaborator

ernado commented Oct 15, 2024

LGTM

Never worked with decimals tho, API in ch-go can be not very friendly and probably can be improved

@ernado ernado merged commit 5f13ec1 into main Oct 15, 2024
25 checks passed
@ernado ernado deleted the decimal-inference branch October 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernado ernado ernado approved these changes

@genzgd genzgd Awaiting requested review from genzgd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @ernado