fix: column type conflicts #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
fix-conflicts
branch
2 times, most recently
from
944bc8d to
e13d46d
Compare
serprex
changed the title
1. `a,b=b,a` would leave `b==c`, always returning false 2. Decimal256 should not conflict with Decimal(76, 38) 3. propagate conflicts to inner types for Nullable/Array/LowCardinality
serprex
force-pushed
the
fix-conflicts
branch
from
e13d46d to
ab04093
Compare
ernado
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a,b=b,awould leaveb==c, always returning falseChecklist