-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KB: Improve KB search - search by title, description (tags) #3160
KB: Improve KB search - search by title, description (tags) #3160
Conversation
…into kb_tagged_search
As discussed:
|
…se-docs into kb_tagged_search_mixed
@gingerwizard @crisalbu tagging for review and testing : https://clickhouse-docs-47khsdid1-clickhouse.vercel.app/docs/knowledgebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk @Blargian !
the breadcrumbs should look and behave in the same way they behave for other categories, see example below:
Thanks @crisalbu, fixed. Here's the latest version: https://clickhouse-docs-kt9adis2h-clickhouse.vercel.app/docs/knowledgebase |
Thanks @Blargian! The title shouldn't change to |
@crisalbu Title and alignment of the breadcrumbs on the article page fixed, latest changes here: https://clickhouse-docs-plc2wgdl4-clickhouse.vercel.app/docs/knowledgebase |
@crisalbu With breadcrumbs for Knowledge Base as two words: https://clickhouse-docs-1icbcs6a3-clickhouse.vercel.app/docs/knowledgebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor but some questions
|
||
[data-theme='light'] .BlogBreadcrumbs .BreadcrumbLink { | ||
color: black; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here @Blargian
let matchedArticles; | ||
let setMatchedArticles; | ||
|
||
if(typeof localStorage !== "undefined") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the value here? why do we need to persist results in local storage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has to do with how the docusaurus blog components are setup, there is no single component for the sidebar, tags page, the recent page and the article page which renders those components conditionally. As a result when you change urls the sidebar re-renders each time and causes these ugly glitching effects. I'm using local storage to persist the current search between page navigations between the different components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reluctantly accepting the state storage between re-renders, not good alternative
|
||
[data-theme='light'] .BlogBreadcrumbs .BreadcrumbLink { | ||
color: black; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here @Blargian
@@ -0,0 +1,3 @@ | |||
.kbTitle{ | |||
margin-bottom: 25px; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
Summary
Uses https://github.com/nextapps-de/flexsearch to do the indexing -> gives us more flexibility in future
Checklist