Add Node.js connection command unit tests

ClickHouse · May 7, 2024 · e2e0fde · e2e0fde
1 parent 27bbafa
commit e2e0fde
Showing 1 changed file with 61 additions and 0 deletions.
diff --git a/packages/client-node/__tests__/unit/node_connection.test.ts b/packages/client-node/__tests__/unit/node_connection.test.ts
@@ -171,6 +171,67 @@ describe('[Node.js] Connection', () => {
       expect(url.search).toContain(`?query_id=${query_id}`)
     })
 
+    it('should generate random query_id for every command request', async () => {
+      const adapter = buildHttpConnection({
+        compression: {
+          decompress_response: false,
+          compress_request: false,
+        },
+      })
+
+      const httpRequestStub = spyOn(Http, 'request')
+
+      const request1 = stubClientRequest()
+      httpRequestStub.and.returnValue(request1)
+
+      const cmdPromise = adapter.command({
+        query: 'SELECT * FROM system.numbers LIMIT 5',
+      })
+      emitResponseBody(request1, 'Ok.')
+      const { query_id } = await cmdPromise
+
+      const request2 = stubClientRequest()
+      httpRequestStub.and.returnValue(request2)
+
+      const cmdPromise2 = adapter.command({
+        query: 'SELECT * FROM system.numbers LIMIT 5',
+      })
+      emitResponseBody(request2, 'Ok.')
+      const { query_id: query_id2 } = await cmdPromise2
+
+      expect(query_id).not.toEqual(query_id2)
+      const [url1] = httpRequestStub.calls.all()[0].args
+      expect(url1.search).toContain(`?query_id=${query_id}`)
+      const [url2] = httpRequestStub.calls.all()[1].args
+      expect(url2.search).toContain(`?query_id=${query_id2}`)
+    })
+
+    it('should use provided query_id for command', async () => {
+      const adapter = buildHttpConnection({
+        compression: {
+          decompress_response: false,
+          compress_request: false,
+        },
+      })
+
+      const httpRequestStub = spyOn(Http, 'request')
+      const request = stubClientRequest()
+      httpRequestStub.and.returnValue(request)
+
+      const query_id = guid()
+      const cmdPromise = adapter.command({
+        query: 'SELECT * FROM system.numbers LIMIT 5',
+        query_id,
+      })
+      emitResponseBody(request, 'Ok.')
+      const { query_id: result_query_id } = await cmdPromise
+
+      expect(httpRequestStub).toHaveBeenCalledTimes(1)
+      const [url] = httpRequestStub.calls.mostRecent().args
+      expect(url.search).toContain(`?query_id=${query_id}`)
+      expect(query_id).toEqual(result_query_id)
+    })
+
     it('should generate random query_id for every insert request', async () => {
       const adapter = buildHttpConnection({
         compression: {