Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override pathname in transformUrl #207

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Don't override pathname in transformUrl #207

merged 2 commits into from
Oct 30, 2023

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Oct 30, 2023

Summary

See the discussion. Before these changes, host such as http://proxy:8123/clickhouse will always lose its /clickhouse pathname segment after the transformUrl call. Now, it is preserved.

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov October 30, 2023 17:02
@slvrtrn slvrtrn mentioned this pull request Oct 30, 2023
Closed
@slvrtrn slvrtrn merged commit c836bb1 into main Oct 30, 2023
23 checks passed
@slvrtrn slvrtrn deleted the update-pathname-logic branch October 30, 2023 19:34
@slvrtrn slvrtrn mentioned this pull request Mar 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slvrtrn @mshustov