Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logger to the ResultSet in the Node.js implementation #265

Merged
merged 5 commits into from
May 17, 2024
Merged

Add Logger to the ResultSet in the Node.js implementation #265

merged 5 commits into from
May 17, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented May 9, 2024

Summary

Related: #263

  • Remove unnecessary error logs from the ResultSet on the ResultSet.close call.
  • Stream error logging uses the Logger instance, which can be provided during the client instance creation (instead of just calling console.error).

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov May 17, 2024 15:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@slvrtrn slvrtrn merged commit ad8611e into main May 17, 2024
29 checks passed
@slvrtrn slvrtrn deleted the add-logger-to-node-result-set branch May 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slvrtrn @mshustov