Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override session id for a particular request #281

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Allow to override session id for a particular request #281

merged 3 commits into from
Jun 6, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Jun 6, 2024

Summary

A follow up for #272
Resolves #271

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov June 6, 2024 18:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@slvrtrn slvrtrn mentioned this pull request Jun 6, 2024
Merged
@slvrtrn slvrtrn merged commit 37aa43d into main Jun 6, 2024
29 checks passed
@slvrtrn slvrtrn deleted the override-session-id branch June 6, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseQueryParams.session_id is not used
3 participants
@slvrtrn @mshustov @Holi0317