Handle errors in a middle of a stream #384
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ResultSet implementation was adjusted given the changes from 24.11 and ClickHouse/ClickHouse#68800; formats like CSV will properly throw by default if an error occurs during the stream.
JSONEachRow
and other streamable formats requirehttp_write_exception_in_output_format: 0
inclickhouse_settings
, so ClickHouse breaks the output stream in a similar way.Important: The
http_write_exception_in_output_format
default value is 1; if it is not modified, the data stream with formats likeJSONEachRow
will not be broken if an error occurs.Here are some curl examples.
This will have exit code 0:
But this will have exit code 18 (see
http_write_exception_in_output_format=0
in the params):Related to #332 and #378
Checklist