Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lz4 with lz4_flex and clickhouse-rs-cityhash-sys with cityhash-rs #131

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

loyd
Copy link
Collaborator

@loyd loyd commented Aug 18, 2024

Now, this crate is pure Rust implementation and doesn't contain any C/C++ dependencies.

lz4-flex doesn't support LZ4HC mode, so Compression::Lz4Hc is deprecated now and becomes alias to Compression::Lz4.

No significant difference in performance is detected:

group                    lz4flex                                master
-----                    -------                                ------
insert/lz4               1.00     56.1±2.14ns   951.7 MB/sec    1.00     56.3±2.01ns   947.9 MB/sec
insert/no compression    1.02     51.6±2.81ns  1035.3 MB/sec    1.00     50.6±2.56ns  1054.5 MB/sec
select/lz4               1.01     39.0±6.11ns   587.1 MB/sec    1.00     38.5±4.14ns   594.5 MB/sec
select/no compression    1.01     30.8±2.82ns   744.0 MB/sec    1.00     30.5±2.98ns   750.2 MB/sec

Closes #107.

@blind-oracle
Copy link
Contributor

Are there plans for a release tag? :)

@loyd loyd merged commit 3ed8b86 into master Aug 20, 2024
5 checks passed
@loyd loyd deleted the feat/pure-rust branch August 20, 2024 09:00
@loyd
Copy link
Collaborator Author

loyd commented Aug 20, 2024

@blind-oracle released in v0.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace clickhouse_rs_cityhash_sys with pure Rust crate cityhash-rs
3 participants