fix: replicated database materializations #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canbekley
changed the title
BentsiLeviav
requested changes
Feb 9, 2025
| @@ -59,14 +59,13 @@ | |||
|
|
|||
| {% macro clickhouse__drop_relation(relation, obj_type='table') -%} | |||
| {% call statement('drop_relation', auto_begin=False) -%} | |||
| {# drop relation on cluster by default if cluster is set #} | |||
| drop {{ obj_type }} if exists {{ relation }} {{ on_cluster_clause(relation.without_identifier(), True)}} | |||
| drop {{ obj_type }} if exists {{ relation }} {{ on_cluster_clause(relation, True)}} | |||
There was a problem hiding this comment.
Could you elaborate more on why to include back the identifier?
There was a problem hiding this comment.
these macros are used to drop/rename tables and other relation types. If the relation doesn't contain an identifier, the ClickHouseRelation.should_on_cluster property will always return True, skipping a check on can_on_cluster. this was causing issues for tables in replicated databases, as they don't support on cluster statements.
| {%- endcall %} | ||
| {% endmacro %} | ||
|
|
||
| {% macro clickhouse__rename_relation(from_relation, to_relation, obj_type='table') -%} | ||
| {% call statement('drop_relation') %} | ||
| drop {{ obj_type }} if exists {{ to_relation }} {{ on_cluster_clause(to_relation.without_identifier())}} | ||
| drop {{ obj_type }} if exists {{ to_relation }} {{ on_cluster_clause(to_relation)}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, table and view materializations wouldn't work with a
Replicateddatabase configured, as they would runON CLUSTERstatements for some of the ddl's. This is not allowed in replicated databases and would lead to the following error:This mr fixes these issues by adding conditions for on cluster statements with replicated databases.
Checklist