Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#563 ] - Hide the CmAppBar when doing the User B conversation and logged in or logged out #580

Conversation

epixieme
Copy link
Collaborator

@epixieme epixieme commented Jun 3, 2024

Detailed information:

[#563] remove the app bar when doing the conversation and logged in
Explain the details of making this change.
Please provide enough information so that others can review your pull request

Created logic in the router.ts file that allows us to hide the CmAppBar for User B's conversation journey only. Used location.pathname to get the path of the routes that are applicable.

Used this to link to a prop in the RoutePage which allows us to pass a boolean to show the CmAppBar

Closing issues:

List all issues the pull request solve:

#562

closes #562

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@epixieme epixieme linked an issue Jun 3, 2024 that may be closed by this pull request
@epixieme epixieme self-assigned this Jun 3, 2024
@epixieme epixieme marked this pull request as draft June 3, 2024 19:07
@epixieme epixieme changed the title 563 remove the app bar when doing the conversation and logged in [#563 ] - Hide the CmAppBar when doing the User B conversation and logged in or logged out Jun 3, 2024
@epixieme epixieme requested a review from Svenstar74 June 3, 2024 19:18
@epixieme epixieme marked this pull request as ready for review June 4, 2024 08:59
Copy link
Collaborator

@Svenstar74 Svenstar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you 😊

@epixieme epixieme merged commit d0c3061 into develop Jun 12, 2024
1 check passed
@epixieme epixieme deleted the 563-remove-the-app-bar-when-doing-the-conversation-and-logged-in branch June 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the app bar when doing the conversation and logged in
2 participants