Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SVDB annotation intermediate rule #1218

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix: SVDB annotation intermediate rule #1218

merged 3 commits into from
Aug 7, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Aug 7, 2023 •
edited
Loading

This PR:

Screenshot 2023-08-07 at 08 59 03

Fixed:

  • Fix SVDB annotation intermediate rule

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team August 7, 2023 07:09
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (749c4bb) 99.37% compared to head (9b04af9) 99.37%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1218   +/-   ##
========================================
  Coverage    99.37%   99.37%           
========================================
  Files           38       38           
  Lines         1905     1905           
========================================
  Hits          1893     1893           
  Misses          12       12
Flag Coverage Δ
unittests 99.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ivadym ivadym merged commit 16e98bc into develop Aug 7, 2023
22 checks passed
@ivadym ivadym deleted the fix-rm-temp branch August 7, 2023 09:40
@ivadym ivadym self-assigned this Sep 22, 2023
@ivadym ivadym mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khurrammaqbool khurrammaqbool khurrammaqbool approved these changes

Assignees

@ivadym ivadym

Labels
None yet
Projects
BALSAMIC
Status: Archived
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivadym @khurrammaqbool