Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase vardict tumor only cores allocation to 18 #1495

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

khurrammaqbool
Copy link
Collaborator

@khurrammaqbool khurrammaqbool commented Oct 23, 2024

Description

During validation, a we noticed that cores allocation for vardict_tumor_only is variable from 5 to 10 for different chromosomes. We did not observe the same problem for tumor-only, which allocates 18 cores, so this PR will increase number of cores from 9 to 18 for vardict_tumor_only.

Fixed

  • Increase allocation of cores for vardict_tumor_only to 18

Removed

  • [Description]

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • [Document Name]

Tests

Feature Tests

  • N/A
  • Test [Description]
    • [Screenshot]

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

Panel of Normal specific criteria

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because [Justification].
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

@khurrammaqbool khurrammaqbool requested a review from a team as a code owner October 23, 2024 10:13
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (03ddaf0) to head (b407b3e).
Report is 1 commits behind head on release_v16.0.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release_v16.0.0    #1495   +/-   ##
================================================
  Coverage            99.49%   99.49%           
================================================
  Files                   40       40           
  Lines                 1991     1991           
================================================
  Hits                  1981     1981           
  Misses                  10       10           
Flag Coverage Δ
unittests 99.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's see if this works 🙏

Copy link

@mathiasbio
Copy link
Collaborator

Tested the new threads on a tumor only case and the provided cores are all 18 now. So assuming that this was the issue, it has been fixed. But let's keep an eye out for it after deployment in case we need to make a fix

@mathiasbio mathiasbio merged commit 7fc67a6 into release_v16.0.0 Oct 23, 2024
7 checks passed
@mathiasbio mathiasbio deleted the fix/vardict_tumor_only_error branch October 23, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants