Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balsamic v16 release #3408

Merged
merged 38 commits into from
Nov 19, 2024
Merged

Balsamic v16 release #3408

merged 38 commits into from
Nov 19, 2024

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jul 8, 2024

Description

NOTE: Do not merge until balsamic release 16.0.0 has been deployed

PR containing all the necessary changes for the Balsamic v16 release.

Changes needed for release 16:

Optional changes for release 16:

Added:

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • workflow integrity tests before start of validation of balsamic has passed:
  • all workflows can be started without error
  • all workflows can be stored, uploaded and delivered without error

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ivadym ivadym removed their assignment Aug 12, 2024
@mathiasbio
Copy link
Contributor

@khurrammaqbool as the tumor only analysis of MSI will not be added for release 16 I assume that I can remove this #3407 from the to do list above? : )

GENS has previously only been activated for WGS in Balsamic, however with the inclusion of this PR into production Clinical-Genomics/BALSAMIC#1448 CNV and BAF profiles from TGA samples can be uploaded as well. This feature is planned for release 16.0.0 of Balsamic (somewhere around **August maybe**) and requires a couple of small changes in CG.

### Added

- gnomad-af argument to TGA samples

### Changed

- gens upload no longer filters out TGA samples
### Added

- new argument for balsamic with new loqusdb vcf for artefact filtering
@mathiasbio mathiasbio marked this pull request as ready for review October 15, 2024 09:03
@mathiasbio mathiasbio requested a review from a team as a code owner October 15, 2024 09:03
@mathiasbio
Copy link
Contributor

Code has been tested in individual PRs merged into this. But all aspects will be tested again during the verification tests before starting validation of balsamic. PR will not be merged until all tests there have been successful!

cg/meta/workflow/balsamic.py Outdated Show resolved Hide resolved
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@mathiasbio mathiasbio merged commit fc24fcd into master Nov 19, 2024
9 checks passed
@mathiasbio mathiasbio deleted the balsamic_v16 branch November 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

6 participants