feat(gunicorn): Add config #3894
Conversation
henrikstranneheim
changed the title
Cg API, 👍
|
| loglevel = "debug" | ||
| protocol = "proxy" | ||
| syslog = True | ||
| forwarded_allow_ips = "10.0.2.100,127.0.0.1" |
There was a problem hiding this comment.
forwarded_allow_ips = "127.0.0.1"
I would suggest having deployment-specific configurations in their respective repo.
There was a problem hiding this comment.
Sounds good, but in a specific future PR.
There was a problem hiding this comment.
But should not the configuration of gunicorn be handled in servers rather than be dictated by code in the repo? If we want to increase the number of workers we shouldn't have to make a PR to cg
There was a problem hiding this comment.
That would be a even bigger change. And I do not know if it would make sense to move it away from the actual app. Either way it is definitively out of scope.
If you agree - could you approve this PR?
There was a problem hiding this comment.
@ahdamin @Vince-janv Bump!
|
Description
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan