Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch TWIST EPPs to take new UDF "Maximum input amount (ng)" into consideration #457

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Patch TWIST EPPs to take new UDF "Maximum input amount (ng)" into consideration #457

merged 4 commits into from
Dec 4, 2023

Conversation

Karl-Svard
Copy link
Collaborator

Added

  • new functions to fetch the maximum input amount of samples

Changed

  • the threshold used when assessing input amounts

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard Karl-Svard marked this pull request as ready for review December 4, 2023 08:05
amandaraud
amandaraud approved these changes Dec 4, 2023
View reviewed changes
Copy link

@amandaraud amandaraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

idalindegaard
idalindegaard approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Karl-Svard Karl-Svard merged commit 0040273 into master Dec 4, 2023
2 checks passed
@Karl-Svard Karl-Svard deleted the max_input_patch branch December 4, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandaraud amandaraud amandaraud approved these changes

@idalindegaard idalindegaard idalindegaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karl-Svard @idalindegaard @amandaraud