Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for normalization script #463

Merged
merged 8 commits into from
Jan 4, 2024

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Dec 21, 2023

Added

Changed

Fixed

If the concentration of the sample(s) "to be normalized" is lower than the aimed for concentration - the script should list all artifact names this concerns in the error message, and set the sample volume to the user-defined total volume and buffer volume to zero.

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard idalindegaard marked this pull request as ready for review January 4, 2024 14:52
Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯👏

@idalindegaard idalindegaard merged commit 22f2db9 into master Jan 4, 2024
2 checks passed
@idalindegaard idalindegaard deleted the update_pool_normalization branch January 4, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants