Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete error msg in file_to_udf #474

Merged
merged 3 commits into from
Feb 21, 2024
Merged

delete error msg in file_to_udf #474

merged 3 commits into from
Feb 21, 2024

Conversation

idalindegaard
Copy link
Contributor

Added

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Karl-Svard
Karl-Svard requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the error handling

cg_lims/EPPs/files/file_to_udf.py Show resolved Hide resolved
cg_lims/EPPs/files/file_to_udf.py Outdated Show resolved Hide resolved
@idalindegaard idalindegaard merged commit 40c3c7f into master Feb 21, 2024
2 checks passed
@idalindegaard idalindegaard deleted the file_to_udf_update branch February 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karl-Svard Karl-Svard Karl-Svard approved these changes

@amandaraud amandaraud Awaiting requested review from amandaraud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idalindegaard @Karl-Svard