Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Skip RC samples in TWIST Aliquot step #475

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

Karl-Svard
Copy link
Collaborator

Added

  • Support for samples that shouldn't be unnecessarily aliquoted.

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor

Tested with some samples in step Aliquot samples for enzymatic fragmentation TWIST
Tested with different concentrations, some very low and some high:
Screenshot 2024-02-27 at 15 43 47
The EPP Calculate Amount needed calculated the amounts as wanted - the minimum amount needed will be the concentration*Volume (of sample), and if there is more than 250 ng, it will be 250ng as wanted for the TGA prep:
Screenshot 2024-02-27 at 15 44 53
The EPP Calculate volumes will give the total aliquotation volume as the number that was chosen in the process UDF "Total Volume (ul)", and there are no negative values because "Amount needed (ng)" is not exceeding "Amount (ng)" anymore:
Screenshot 2024-02-27 at 15 45 38

Conclusion: The update works as it should and the changes can be merged!

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Karl! 🔥

@Karl-Svard Karl-Svard merged commit 1466d79 into master Feb 27, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the skip_rc_aliquot branch February 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants