Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script: Saphyr average concentration and CV calculation #479

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Mar 19, 2024

Added

New script to calculate average concentration and CV value for Saphyr samples

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard idalindegaard changed the title Saphyr average concentration Saphyr average concentration and CV calculation Mar 19, 2024
@idalindegaard idalindegaard changed the title Saphyr average concentration and CV calculation New script: Saphyr average concentration and CV calculation Mar 19, 2024
@idalindegaard
Copy link
Contributor Author

idalindegaard commented Mar 20, 2024

Testing the script on stage with positive, negative and zero/no values:

All positive values:
Screenshot 2024-03-20 at 10 40 24

One negative value:
Screenshot 2024-03-20 at 10 41 17

One zero value:
Screenshot 2024-03-20 at 10 42 06

One artifact with no values:
Screenshot 2024-03-20 at 10 42 40

Three artifacts with no/zero/negative values plus the log file with more information (marked pink in picture) about which sample IDs (and which Concentration 1-3) were affected:
Screenshot 2024-03-20 at 10 55 57

The tests show that the script counts all artifacts that have no/zero/negative values for any of the Concentrations 1-3 (ng/ul) and lets the user know it, you can read more in the log file about which samples had invalid values. In case this happens, the scripts stops after it has checked all the concentrations and won't continue to calculate the CV och Average concentration (ng/ul)

Conclusion: The script works as intended.

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! 🔥🔥🔥

I think it's ready for merging. Unless of course you have some other feature you'd like to add first

@idalindegaard
Copy link
Contributor Author

Very nice!! 🔥🔥🔥

I think it's ready for merging. Unless of course you have some other feature you'd like to add first

Thanks @Karl-Svard! 😀

It says I have some conflicts that need to be resolved. Do you understand what to do?

@Karl-Svard
Copy link
Collaborator

Yeah, some of the recent PRs are modifying the same lines in the base.py of the calculate EPPs. But it can easily be fixed in the browser. We can go through it together when you have the time :)

@idalindegaard idalindegaard merged commit 649cab5 into master Mar 26, 2024
2 checks passed
@idalindegaard idalindegaard deleted the saphyr_average_concentration branch March 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants