Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change constants for minimum lane volume #526

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Sep 11, 2024

Added

Changed

  • Constants for minimum volume per lane for flowcells 1.5, 10 and 25B with +1ul. see lims issue 522

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just one question, won't this affect the ratio of denaturation agents and such?

@idalindegaard
Copy link
Contributor Author

👍

Thanks for the review, I was also planning on doing a quick test and add screenshots.

Just one question, won't this affect the ratio of denaturation agents and such?

Good question! This will not affect the ratio of reagents since this is not the final volume taken to the denaturation process and further to the library tube strip. The volume affected is just the bulk pool volume from which we will aliquot to a plate (where the denaturation process will take place)

@idalindegaard
Copy link
Contributor Author

idalindegaard commented Sep 13, 2024

Testing the volume calculation with the 1.5B, 10B and 25B flowcell modes, first with one lane and then with eight lanes with a minimal sample volume - the screenshots below show a desired result. With eight lanes the Adjusted bulk pool volume should be 8*(changed volume constant).
Screenshot 2024-09-13 at 15 36 27
Screenshot 2024-09-13 at 15 42 23
Screenshot 2024-09-13 at 15 42 46
Screenshot 2024-09-13 at 15 44 11
Screenshot 2024-09-13 at 15 43 40

The change of the volume constants does not change the settings/view in the Make Pool and Denature (NovaSeq X) step - which is correct, the volume change is only supposed to change the Adjusted bulk pool volume from which we take the volumes that are supposed to be denatured later. See image below.
Screenshot 2024-09-13 at 15 48 07

@idalindegaard idalindegaard merged commit 5cd695a into master Sep 13, 2024
2 checks passed
@idalindegaard idalindegaard deleted the raise_minimum_volume branch September 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants