Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New library normalization script for Revio #558

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Nov 18, 2024

Added

  • new script file in EPPs>udfs>calculate named library_normalization_revio.py
  • updated base.py with the new script
  • added+moved out some functions that are used in both the new script and in library_normalization.py

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor Author

Testing of new and updated scripts

Step: Normalization of Revio (WGS) samples for sequencing v1

New EPP "Calculate Volume Normalization (Revio)"

bash -c -l "conda activate cg_lims &&  lims -c  /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid}  udf calculate library-normalization-revio -sudf 'Volume (ul)' -b 'Volume Buffer (ul)' --concentration-udf 'Concentration' --final-concentration-udf 'Final Concentration (ng/ul)' --total-volume-udf 'Total Volume (ul)'"

Before running the EPP:
Screenshot 2024-11-18 at 16 24 29
Successful calculation of volumes:
Screenshot 2024-11-18 at 16 24 45
Error messages when the sample concentration is lower than the target concentration:
Screenshot 2024-11-18 at 16 32 23
Error messages with missing value for the Volume (ul) udf
Screenshot 2024-11-18 at 16 32 54
Error messages with missing value for the Concentration udf
Screenshot 2024-11-18 at 16 33 35

Step: Normalization of WGS samples for sequencing v1

No EPP change.

Successful calculation of volumes:
Screenshot 2024-11-18 at 16 35 19
Error message when the sample concentration is lower than the target concentration:
Screenshot 2024-11-18 at 16 53 40
Error message with missing value for the Concentration (nM) udf
Screenshot 2024-11-18 at 16 53 59
Error log:
Screenshot 2024-11-18 at 16 54 20

Conclusion: The tests were successful! The new script+EPP works and nothing broke in the updated library normalization script

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🔥

I did some very minor commits that you could take a look at if you're interested

@idalindegaard idalindegaard merged commit 8bb8159 into master Nov 19, 2024
2 checks passed
@idalindegaard idalindegaard deleted the revio_library_normalization branch November 19, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants