Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and refactor pooling map EPP #559

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Update and refactor pooling map EPP #559

merged 5 commits into from
Nov 22, 2024

Conversation

Karl-Svard
Copy link
Collaborator

@Karl-Svard Karl-Svard commented Nov 21, 2024

Changed

  • Added pool sorting to the pooling map
  • Changed the color set
  • Added new flag, -r/ --round-decimals for determining the amount of rounding
  • Made the coloring truly container specific, and not pool-container as was before

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

Karl-Svard commented Nov 21, 2024

Example output generated from step https://cg-lims-stage.sys.scilifelab.se/clarity/work-details/553687

Old TWIST pooling script:
Screenshot 2024-11-21 at 19 15 38

New script on the same TWIST step:
Screenshot 2024-11-21 at 19 14 47

Note: The placement of the sample and pooling values are determined by the order in which they are added to the CLI

@Karl-Svard
Copy link
Collaborator Author

Karl-Svard commented Nov 22, 2024

The command used to generate the TWIST pooling maps:

lims -c  <config path> epps -l <log path> -p <process ID> files pool-map -f <file name> -pu 'Volume H2O (ul)' -pu 'Total Amount (ng)' -pu 'Total Volume (ul)' -su 'Volume of sample (ul)' -su 'Amount taken (ng)' -su 'Amount (ng)' -r 2

The changes introduced shouldn't affect the syntax of the covid pooling map. So already configured EPPs will work out of the box

Copy link

@AbiDalby AbiDalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Karl-Svard Karl-Svard merged commit 21e4640 into master Nov 22, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the update_pooling_map branch November 22, 2024 07:38
@Karl-Svard
Copy link
Collaborator Author

Karl-Svard commented Nov 22, 2024

The "Make TWIST pooling Map" EPP has been updated as well.

From:

bash -c "/home/glsai/miniconda3/envs/epp_master/bin/make_twist_pooling_map.py --pid {processLuid} --res {compoundOutputFileLuid1}"

To:

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid} files pool-map -f  {compoundOutputFileLuid1} -pu 'Total Amount (ng)' -pu 'Total Volume (ul)' -pu 'Volume H2O (ul)' -su 'Volume of sample (ul)' -su 'Amount taken (ng)' -su 'Amount (ng)' -r 2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants