Skip to content

Commit

Permalink
Add warning and correct urls
Browse files Browse the repository at this point in the history
  • Loading branch information
fellen31 committed Nov 14, 2024
1 parent e45ff43 commit d2dca53
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Try to use the following format:
- The optional fields Source and Version are allowed in the VCF header([#106](https://github.com/Clinical-Genomics/genmod/pull/106))
- Released the constraint on Python 3.8 (collections, pkg_resources to importlib, tests) ([#142](https://github.com/Clinical-Genomics/genmod/pull/142))
- Update annotation examples ([#144](https://github.com/Clinical-Genomics/genmod/pull/144))

- Updated documentation with warning about compounds only being scored within the first family in the VCF ([#151](https://github.com/Clinical-Genomics/genmod/pull/151))

## [3.9]
- Fixed wrong models when chromosome X was named `chrX` and not `X` ([#135](https://github.com/Clinical-Genomics/genmod/pull/135))
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/build-annotation.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ Options:
## Overview ##

The build command is used for building new annotations. This could be used if another gene defenition than default (refSeq) are preferred, if other regions than genes should be used to annotate compounds or if another organism than humans are used in the analysis.
The supported formats are `bed, ccds, gtf, gene_pred, gff`. Small examples for the supported formats in [conftest.py](https://github.com/moonso/genmod/blob/master/tests/conftest.py)
The supported formats are `bed, ccds, gtf, gene_pred, gff`. Small examples for the supported formats in [conftest.py](https://github.com/Clinical-Genomics/genmod/blob/master/tests/conftest.py)
5 changes: 4 additions & 1 deletion docs/commands/score-compounds.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

This module performs ranking of compound variants.

> [!WARNING]
> Ranking of compound variants is only done for the the first family in the VCF.
During the ranking of these compounds the rank score might be modified in place.
See `genmod/score_variants/compound_scorer.py:L248`.

Expand All @@ -17,4 +20,4 @@ or `(0, 1)` if it's of `RankScoreNormalized` type.

In previous Genmod versions there were no such capping rule in effect.
Earlier ranked variants from `compounds` module might show lower rank
scores compared to this implementation.
scores compared to this implementation.

0 comments on commit d2dca53

Please sign in to comment.