Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable variants in models output #134

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix unstable variants in models output #134

merged 1 commit into from
Sep 24, 2024

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented Sep 23, 2024 •
edited
Loading

Description

This PR sorts the scored_compound_list before writing, so that the output VCF always looks the same for a given input.

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fellen31 fellen31 linked an issue Sep 23, 2024 that may be closed by this pull request
Unstable compounds order in output from genmod models #133
Closed
@fellen31 fellen31 force-pushed the sort-compounds branch 7 times, most recently from 3926a80 to bbede9a Compare September 23, 2024 15:16
@fellen31 fellen31 marked this pull request as ready for review September 23, 2024 15:17
torbjorgen
torbjorgen approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@torbjorgen torbjorgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@fellen31 fellen31 merged commit 68bc1ed into Clinical-Genomics:master Sep 24, 2024
1 check passed
@fellen31 fellen31 deleted the sort-compounds branch September 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torbjorgen torbjorgen torbjorgen approved these changes

@dnil dnil Awaiting requested review from dnil

@jemten jemten Awaiting requested review from jemten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable compounds order in output from genmod models
2 participants
@fellen31 @torbjorgen