Add GitHub Actions workflows for PyPI and CHANGELOG #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fellen31
force-pushed
the
publish-to-pypi
branch
2 times, most recently
from
d6842ce
to
fd4efe9
Compare
fellen31
force-pushed
the
publish-to-pypi
branch
from
fd4efe9
to
821b7ba
Compare
|
Sry, I missed the notification for this. Will check later if it is still open! |
dnil
approved these changes
Oct 8, 2024
|
|
||
| ## [3.8.3] | ||
|
|
||
| - Fixed unstable compounds order in models output ([#134](https://github.com/Clinical-Genomics/genmod/pull/134))) | ||
| - Added `six` to requirements.txt and setup.py ([#134](https://github.com/Clinical-Genomics/genmod/pull/134))) | ||
| - Fixed unstable compounds order in models output ([#134](https://github.com/Clinical-Genomics/genmod/pull/134)) |
| bdist_wheel | ||
|
|
||
| - name: Publish distribution 📦 to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 |
There was a problem hiding this comment.
I think this will work quite well as is, based on Stranger and https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/. But if there are any problems with setting a trusted GitHub repo, remember you can back up and use a tokenized version as well. I note I'm not a PyPi admin for this repo, but there are plenty so just ask e.g. @jemten or @torbjorgen to follow the instructions in this link an all should be good.
Great, thanks for taking a look @dnil. |
This was referenced Oct 24, 2024
Merged
dnil
added a commit
that referenced
this pull request
Oct 24, 2024
Co-authored-by: Daniel Nilsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I copied two of the workflows added by @dnil to Stranger, not sure how to properly setup/test that the automatic publishing works.
Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan