Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release restriction on Python 3.8 (collections import) #142

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Release restriction on Python 3.8 (collections import) #142

merged 13 commits into from
Nov 4, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Oct 24, 2024 •
edited
Loading

Description

  • release restrictions on newer versions of python (collections import) and update tests, workflows to 3.12

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@dnil dnil marked this pull request as draft October 24, 2024 08:50
@dnil dnil marked this pull request as ready for review October 24, 2024 12:41
@dnil
Copy link
Collaborator Author

dnil commented Oct 24, 2024

Well, and here I was saying to myself, echoing what previous speakers have said: we should migrate install to poetry as we move to 3.8. But then I went, let's just leave 3.8 first, and do poetry separately not to change too much. Famous last words.
But here we are.

  • free from constraints on 3.8
  • 3.13 in tests and docker
  • still on setup, so should not affect any deploy automation or such

@dnil dnil requested a review from fellen31 October 24, 2024 12:48
jemten
jemten approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @dnil! As you say in your comment it would be good to eventually move to poetry.

Confirmed to be working for ranking SNVs on a full test case, python version 3.12

genmod/__init__.py

try:
from importlib.metadata import version
except ImportError: # Backport support for importlib metadata on Python 3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very considerate to not drop support for python 3.7 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are after all just barely leaving it formally. Though the jump to 3.13 is considerable. 😊

@dnil dnil merged commit a23e8d7 into master Nov 4, 2024
2 checks passed
@dnil dnil deleted the unfreeze_python38 branch November 4, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemten jemten jemten approved these changes

@fellen31 fellen31 Awaiting requested review from fellen31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnil @jemten