Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates from lund #94

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Merge updates from lund #94

merged 9 commits into from
Oct 25, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Oct 25, 2024

This PR adds a functionality or fixes a bug.

Merging fixes from Lund (16 commits ahead, but some are merge commits and duplicates). I think this should be it! Leaving a 2.1.2 version in the CHANGELOG, but clearly marked as "Lund" since Solna never had it. Also duplicating these changes to Unreleased in the CHANGELOG with a clear note.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11521921343

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 20.396%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gens/api.py 0 1 0.0%
gens/db/annotation.py 0 1 0.0%
Totals Coverage Status
Change from base Build 11521002836: 0.07%
Covered Lines: 247
Relevant Lines: 1211

💛 - Coveralls

@dnil dnil merged commit c74e2c5 into master Oct 25, 2024
7 checks passed
@dnil dnil deleted the merge_updates_from_lund branch October 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants