Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11, bump version to 1.2.1 #14

Merged
merged 2 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/push_build_latest_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ jobs:
with:
submodules: 'recursive'

- name: Get branch name
id: branch-name
uses: tj-actions/branch-names@v7

- name: Publish main image (Dockerfile) to Registry
uses: elgohr/Publish-Docker-Github-Action@v5
with:
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Changelog


### [1.2.1]
#### Fixed
- Docker prod build
- Docker stage builds use branch name

### [1.2.0]
#### Added
- A CHANGELOG
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ WORKDIR /app
COPY package*.json .
COPY tsconfig.json .
RUN npm install
RUN npm build
COPY . .

COPY . .

RUN npm run build
EXPOSE 5173
CMD ["npm", "run", "preview"]
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@ npm install
npm run dev
```

For a production ready deployment, run
```
npm install
npm run build
```
Optionally test that the `dist` build looks good with
```
npm run preview
```

## Credits

This service/product uses the Human Phenotype Ontology (version information). Find out more at http://www.human-phenotype-ontology.org
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "react-ts",
"private": true,
"version": "1.2.0",
"version": "1.2.1",
"type": "module",
"scripts": {
"dev": "vite",
Expand Down