Fixed ReadInputRegisters Server Function

+ fixed the test so it catches the bug I introduced earlier
Cloud-Automation · Nov 22, 2016 · 731a704 · 731a704
1 parent 195dd32
commit 731a704
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/handler/server/ReadInputRegisters.js b/src/handler/server/ReadInputRegisters.js
@@ -55,8 +55,7 @@ module.exports = stampit()
                 head.writeUInt8(0x04, 0);
                 head.writeUInt8(quantity * 2, 1);
 
-                var response = Buffer.concat([head, mem.slice(byteStart * 2, byteStart * 2 + quantity * 2)]);
-
+                var response = Buffer.concat([head, mem.slice(byteStart, byteStart + quantity * 2)]);
 
                 cb(response);
 

diff --git a/test/modbus-server-core.test.js b/test/modbus-server-core.test.js
@@ -267,8 +267,8 @@ describe("Modbus Server Core Tests.", function () {
         it('should handle a read input registers request just fine.', function (done) {
 
             var core        = Core(),
-                request     = Buffer.from([0x04,0x00,0,0x00,5]),
-                exResponse  = Buffer.from([0x04,10,0x00,5,0x00,4,0x00,3,0x00,2,0x00,1]);          
+                request     = Buffer.from([0x04,0x00,0x01,0x00,0x04]),
+                exResponse  = Buffer.from([0x04,0x08,0x00,4,0x00,3,0x00,2,0x00,1]);          
             core.getInput().writeUInt16BE(0x05, 0); 
             core.getInput().writeUInt16BE(0x04, 2); 
             core.getInput().writeUInt16BE(0x03, 4);