Upgrade leveldb-mcpe bindings to 0.0.10-SNAPSHOT and optimize chunk (de)serialization #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupremeMortal
previously approved these changes
Jul 31, 2020
|
Any progress on this? |
|
I was having some issues before, but held off because the block states still weren't entirely functional. Will give it another look when I get home. |
# Conflicts: # src/main/java/org/cloudburstmc/server/level/generator/standard/generation/density/EndDensitySource.java
|
i'm not sure what changed, but this seems to be working now when it wasn't before. still, it would be good if a few people other than myself could test it (just go around, change a bunch of blocks, restart the server and make sure they're all still there and the server doesn't catch fire) before we consider it "safe" to merge. |
|
Re-opening for visibility at a possible future date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work in theory, but I can't test it yet due to the fact that
feature/block-statesdoesn't compile.