Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom configuration for validator initcontainer resources #146

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Allow custom configuration for validator initcontainer resources #146

wants to merge 2 commits into from
+4 −0

Conversation

AnnaWinnick
Copy link

@AnnaWinnick AnnaWinnick commented Jan 23, 2025 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the CloudZero Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Allows custom resource configuration for init containers

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@AnnaWinnick AnnaWinnick requested a review from a team as a code owner January 23, 2025 23:09
dmepham
dmepham requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@dmepham dmepham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the contribution! though, I think there is an indentation issue.

it also would be nice to have this option added and commented out in the values.yaml to guide future readers

charts/cloudzero-agent/templates/deploy.yaml Outdated Show resolved Hide resolved
@AnnaWinnick AnnaWinnick requested a review from dmepham February 3, 2025 17:50
dmepham
dmepham approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dmepham dmepham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmepham dmepham dmepham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaWinnick @dmepham