Dev: unittests: Rewrite test_findln_by_timestamp by using fixed date #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/unittests/test_report_utils.py
Outdated
| target_time_stamp = crmutils.parse_to_timestamp(target_time+' '+str(this_year)) | ||
| target_time_str = "Apr 03 13:10" | ||
| target_time = datetime.datetime.strptime(target_time_str, "%b %d %H:%M") | ||
| now = datetime.datetime.now() |
There was a problem hiding this comment.
Can you use some stable test cases, instead of relying on current time?
liangxin1300
force-pushed
the
20250102_ut_error
branch
from
dab4d53 to
e513b9f
Compare
liangxin1300
changed the title
nicholasyang2022
approved these changes
Jan 2, 2025
liangxin1300
added a commit
that referenced
this pull request
Jan 6, 2025
Some test cases should be duplicated after #1650 merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1649