Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: show logs of test failures #316

Closed
wants to merge 1 commit into from
Closed

travis: show logs of test failures #316

wants to merge 1 commit into from

Conversation

grooverdan
Copy link
Contributor

if tests fail may as well see what the logs say.

@knet-ci-bot
Copy link

Can one of the admins verify this patch?

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

Respective Travic CI failure (job 622.1) looks like exactly the instance
#315 aims to fix. I wonder if anything in autotools changed since
I don't remember seeing anything like this before.

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

Indeed, I've seen actually, as just stated at #315.

Regarding the problem at hand, I'd note that in the past, I remember
that the automake's test-driver based tests were "verbose" (rather
excessively since it was regardless whether any failure occurred)
without any additional effort, which may have changed once these
build tools got updated.

Note that better solution than doing it at the Travis level is to
enable it directly on the automake's side, by passing VERBOSE=1
to any kind of make *check.

Looking at the history, I see I've actually dropped that with
commit 4546106. But at this
point, I frankly don't remember whether it was intentional
(because of said previous verbose default), or accidental
(have I confused VERBOSE=1 with V=1?). Perhaps we should
return that back.

But looking at said CI failure, all tests were actually green
(so VERBOSE=1 would not help, anyway), and then, all of
a sudden, a coredump is present. So it looks to me as if
some assumptions about "signalled process will appear as if
it exited with status >127" is fundamentally broken and
needs to be investigated first before we proceed on this item.

In other word, #315 needs a proper attention first, IMHO.

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 24, 2018

But looking at said CI failure, all tests were actually green
(so VERBOSE=1 would not help, anyway)

For completeness, this Travis CI job 622.1 [1] proves that the current
diagnostics introduced in this very PR won't help...

[1]
https://travis-ci.org/ClusterLabs/libqb/jobs/418594333
https://api.travis-ci.org/v3/job/418594333/log.txt

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 27, 2018

Just an aside, current Travis CI run failed because of the residual core files
that #315 aims to solve.

@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 28, 2018

Pushed by hand (didn't trigger autoclose).
Thanks!

@jnpkrn jnpkrn closed this Aug 28, 2018
@jnpkrn
Copy link
Contributor

jnpkrn commented Aug 28, 2018

4b7ffd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants